twalthr commented on a change in pull request #6927: [FLINK-10624] Extend SQL client end-to-end to test new KafkaTableSink URL: https://github.com/apache/flink/pull/6927#discussion_r232257714
########## File path: flink-end-to-end-tests/flink-sql-client-test-kafka-0.10/pom.xml ########## @@ -0,0 +1,165 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; Review comment: Yes, the plugin that you mentioned is responsible for collecting the jars. However, the dependencies in the `pom.xml` just force Maven to transitively compile the fat SQL jars in their modules. We need to add the dependencies for cases when people just build the `flink-end-to-end` module such that all transitive modules are built as well. Dependency clashes can only occur in the SQL Client test script, but this can be easily handled by explicitly specify which jars to use with `--jar`. If this were a regular Maven project you would be right, but this is more of a helper Maven project, not a typical Flink job project. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
