[ 
https://issues.apache.org/jira/browse/FLINK-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681085#comment-16681085
 ] 

ASF GitHub Bot commented on FLINK-10827:
----------------------------------------

zentol commented on issue #7061: [FLINK-10827][tests] Add test for duplicate() 
to SerializerTestBase
URL: https://github.com/apache/flink/pull/7061#issuecomment-437292479
 
 
   Related test-failure:
   ```
   
testDuplicate(org.apache.flink.api.java.typeutils.runtime.PojoSubclassSerializerTest)
  Time elapsed: 0.101 sec  <<< ERROR!
   java.lang.IllegalStateException: Concurrent access to KryoSerializer. Thread 
1: Thread-240 , Thread 2: Thread-241
        at 
org.apache.flink.api.java.typeutils.runtime.kryo.KryoSerializer.enterExclusiveThread(KryoSerializer.java:623)
        at 
org.apache.flink.api.java.typeutils.runtime.kryo.KryoSerializer.copy(KryoSerializer.java:211)
        at 
org.apache.flink.api.java.typeutils.runtime.PojoSerializer.copy(PojoSerializer.java:256)
        at 
org.apache.flink.api.common.typeutils.SerializerTestBase$SerializerRunner.run(SerializerTestBase.java:597)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add test for duplicate() to SerializerTestBase
> ----------------------------------------------
>
>                 Key: FLINK-10827
>                 URL: https://issues.apache.org/jira/browse/FLINK-10827
>             Project: Flink
>          Issue Type: Test
>          Components: Tests
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> In the past, we had many bugs from type serializers that have not properly 
> implemented the {{duplicate()}} method in a proper way. A very common error 
> is to forget about creating a deep copy of some fields that can lead to 
> concurrency problems in the backend.
> We should add a test case for that tests duplicated serializer from different 
> threads to expose concurrency problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to