[ 
https://issues.apache.org/jira/browse/FLINK-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681072#comment-16681072
 ] 

Stefan Richter commented on FLINK-10828:
----------------------------------------

When I was talking to [~trohrm...@apache.org], he said that we have already a 
similar test, checking that all implementations of a certain interface are 
tested, but I don't remember which test that was. So my assumption is we can do 
something similar here. For the second part, I think there is no alternative to 
manually checking this. But it also only applies to some serializers. We could 
simplify this by creating a wrapper that can make any serializer artifiacially 
stateful, e.g. by buffering the reads and writes etc., so that we can still use 
simple stuff likeĀ {{IntSerializer}} and just wrap if we use it as an inner 
serializer.

> Enforce that all TypeSerializers are tested through SerializerTestBase
> ----------------------------------------------------------------------
>
>                 Key: FLINK-10828
>                 URL: https://issues.apache.org/jira/browse/FLINK-10828
>             Project: Flink
>          Issue Type: Test
>          Components: Tests
>            Reporter: Stefan Richter
>            Priority: Major
>
> As pointed out in FLINK-10827, type serializers are a common source of bugs 
> and we should try to enforce that every type serializer (that is not 
> exclusive to tests) is tested at least through a test that extends the 
> {{SerializerTestBase}}. We should also check that the tests of composite 
> serializers use inner serializers that are stateful and require proper 
> duplication, or else the tests can pass even if inner serializers are not 
> properly duplicated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to