[ 
https://issues.apache.org/jira/browse/FLINK-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676866#comment-16676866
 ] 

vinoyang commented on FLINK-10771:
----------------------------------

OK, since it may be used, why don't we refactor it as: if it's not explicitly 
set, then use the default value of the config option (rather than hard-coded 
strings) uniformly?

> Replace hard code of job graph file path with config option for 
> FileJobGraphRetriever
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-10771
>                 URL: https://issues.apache.org/jira/browse/FLINK-10771
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>
> There is a config option to configure the value :
> {code:java}
> public static final ConfigOption<String> JOB_GRAPH_FILE_PATH = ConfigOptions
>    .key("internal.jobgraph-path")
>    .defaultValue("job.graph");
> {code}
> However, we used the default hard code in AbstractYarnClusterDescriptor. 
> This is just a preliminary refactoring, and I finally recommend that we use 
> Zookeeper-based storage. It has been implemented in FLINK-10292.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to