[
https://issues.apache.org/jira/browse/FLINK-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675191#comment-16675191
]
ASF GitHub Bot commented on FLINK-10711:
----------------------------------------
zentol commented on a change in pull request #7023: [FLINK-10711] [e2e] Allow
basic error handling with bash
URL: https://github.com/apache/flink/pull/7023#discussion_r230758636
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -347,19 +353,24 @@ function check_logs_for_exceptions {
| grep -v "java.lang.Exception: Execution was suspended" \
| grep -v "java.io.InvalidClassException:
org.apache.flink.formats.avro.typeutils.AvroSerializer" \
| grep -v "Caused by: java.lang.Exception: JobManager is shutting down" \
- | grep -ic "exception")
+ | grep -ic "exception" || true)
Review comment:
will this not _always_ return true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> flink-end-to-end-tests can fail silently
> ----------------------------------------
>
> Key: FLINK-10711
> URL: https://issues.apache.org/jira/browse/FLINK-10711
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.7.0
> Reporter: Piotr Nowojski
> Assignee: Timo Walther
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Because they are written in bash and they are not setting
> {code:bash}
> set -e
> {code}
> at the beginning, errors can be swallowed silently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
