bowenli86 commented on a change in pull request #6970: [FLINK-10696][Table API 
& SQL]Add APIs to ExternalCatalog, CrudExternalCatalog and 
InMemoryCrudExternalCatalog for views and UDFs
URL: https://github.com/apache/flink/pull/6970#discussion_r230216165
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/InMemoryExternalCatalog.scala
 ##########
 @@ -98,6 +101,77 @@ class InMemoryExternalCatalog(name: String) extends 
CrudExternalCatalog {
     }
   }
 
+  @throws[ViewAlreadyExistException]
+  override def createView(
+    viewName: String,
+    view: String,
 
 Review comment:
   sounds good!
   
   - 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to