[
https://issues.apache.org/jira/browse/FLINK-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672058#comment-16672058
]
ASF GitHub Bot commented on FLINK-10696:
----------------------------------------
xuefuz commented on a change in pull request #6970: [FLINK-10696][Table API &
SQL]Add APIs to ExternalCatalog, CrudExternalCatalog and
InMemoryCrudExternalCatalog for views and UDFs
URL: https://github.com/apache/flink/pull/6970#discussion_r230161785
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/InMemoryExternalCatalog.scala
##########
@@ -98,6 +101,77 @@ class InMemoryExternalCatalog(name: String) extends
CrudExternalCatalog {
}
}
+ @throws[ViewAlreadyExistException]
+ override def createView(
+ viewName: String,
+ view: String,
Review comment:
I think it might be good to define a View class following the descriptor
approach, though the only thing significant might be just a query as a string.
However, this can be taken as a followup JIRA.
I will update the doc accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add APIs to ExternalCatalog for views and UDFs
> ----------------------------------------------
>
> Key: FLINK-10696
> URL: https://issues.apache.org/jira/browse/FLINK-10696
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.6.1
> Reporter: Xuefu Zhang
> Assignee: Bowen Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> Currently there are APIs for tables only. However, views and UDFs are also
> common objects in a catalog.
> This is required when we store Flink tables/views/UDFs in an external
> persistent storage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
