xuefuz commented on a change in pull request #6970: [FLINK-10696][Table API & SQL]Add APIs to ExternalCatalog, CrudExternalCatalog and InMemoryCrudExternalCatalog for views and UDFs URL: https://github.com/apache/flink/pull/6970#discussion_r230159003
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala ########## @@ -103,4 +105,86 @@ trait CrudExternalCatalog extends ExternalCatalog { @throws[CatalogNotExistException] def alterSubCatalog(name: String, catalog: ExternalCatalog, ignoreIfNotExists: Boolean): Unit + /** + * Adds a view to this catalog. + * + * @param viewName The name of the view to add. + * @param view The view to add. + * @param ignoreIfExists Flag to specify behavior if a view with the given name already exists: + * if set to false, throw an exception, + * if set to true, nothing happens. + * @throws ViewAlreadyExistException thrown if view already exists and ignoreIfExists is false + */ + @throws[ViewAlreadyExistException] + def createView(viewName: String, view: String, ignoreIfExists: Boolean): Unit + + /** + * Deletes a view from this catalog. + * + * @param viewName Name of the view to delete. + * @param ignoreIfNotExists Flag to specify behavior if the view does not exist: + * if set to false, throw an exception, + * if set to true, nothing happens. + * @throws ViewNotExistException thrown if the view does not exist in the catalog + */ + @throws[ViewNotExistException] + def dropView(viewName: String, ignoreIfNotExists: Boolean): Unit + + /** + * Modifies an existing view of this catalog. + * + * @param viewName The name of the view to modify. + * @param view The new view which replaces the existing table. Review comment: Typo: table -> view ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services