[
https://issues.apache.org/jira/browse/FLINK-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671640#comment-16671640
]
ASF GitHub Bot commented on FLINK-10638:
----------------------------------------
twalthr commented on a change in pull request #6981: [FLINK-10638][table]
Invalid table scan resolution for temporal join queries
URL: https://github.com/apache/flink/pull/6981#discussion_r230049212
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/TemporalJoinITCase.scala
##########
@@ -142,11 +140,16 @@ class TemporalJoinITCase extends
StreamingWithStateTestBase {
tEnv.registerTable("Orders", orders)
tEnv.registerTable("RatesHistory", ratesHistory)
+ tEnv.registerTable("FilteredRatesHistory",
tEnv.scan("RatesHistory").filter('rate > 110L))
tEnv.registerFunction(
"Rates",
- ratesHistory.createTemporalTableFunction('rowtime, 'currency))
+ tEnv.scan("FilteredRatesHistory").createTemporalTableFunction('rowtime,
'currency))
+ tEnv.registerTable("TemporalJoinResult", tEnv.sqlQuery(sqlQuery))
- val result = tEnv.sqlQuery(sqlQuery).toAppendStream[Row]
+ // Scan from registered table to test for interplay between
+ // LogicalCorrelateToTemporalTableJoinRule and TableScanRule
+ val result = tEnv.scan("TemporalJoinResult").toAppendStream[Row]
+ System.out.println(tEnv.explain(tEnv.sqlQuery(sqlQuery)))
Review comment:
Remove `println`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid table scan resolution for temporal join queries
> -------------------------------------------------------
>
> Key: FLINK-10638
> URL: https://issues.apache.org/jira/browse/FLINK-10638
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Registered tables that contain a temporal join are not properly resolved when
> performing a table scan.
> A planning error occurs when registering a table with a temporal join and
> reading from it again.
> {code}
> LogicalProject(amount=[*($0, $4)])
> LogicalFilter(condition=[=($3, $1)])
> LogicalCorrelate(correlation=[$cor0], joinType=[inner],
> requiredColumns=[{2}])
> LogicalTableScan(table=[[_DataStreamTable_0]])
>
> LogicalTableFunctionScan(invocation=[Rates(CAST($cor0.rowtime):TIMESTAMP(3)
> NOT NULL)], rowType=[RecordType(VARCHAR(65536) currency, BIGINT rate, TIME
> ATTRIBUTE(ROWTIME) rowtime)], elementType=[class [Ljava.lang.Object;])
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
