[
https://issues.apache.org/jira/browse/FLINK-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669657#comment-16669657
]
ASF GitHub Bot commented on FLINK-9569:
---------------------------------------
tzulitai commented on issue #6151: [FLINK-9569] [avro] Fix confusing
construction of GenericRecord AvroSerializers
URL: https://github.com/apache/flink/pull/6151#issuecomment-434570848
This PR is no longer relevant. Closing this ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Confusing construction of AvroSerializers for generic records
> -------------------------------------------------------------
>
> Key: FLINK-9569
> URL: https://issues.apache.org/jira/browse/FLINK-9569
> Project: Flink
> Issue Type: Improvement
> Components: Type Serialization System
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Major
> Labels: pull-request-available
>
> The {{AvroSerializer}} currently has a {{AvroSerializer(Class<T> type, Schema
> schema)}} public constructor when used for generic records.
> This is a bit confusing, because when using the \{{AvroSerializer}}, the type
> to be serialized should always be a {{GenericData.Record}} type.
> We should either:
> - have a separate subclass of {{AvroSerializer}}, say
> {{GenericRecordAvroSerializer}} that is a {{AvroSerializer<GenericRecord>}},
> or
> - follow a similar approach to the instantiation methods in the
> {{AvroDeserialiationSchema}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
