igalshilman commented on a change in pull request #6966: [FLINK-10166] [table] Reduce dependencies by removing org.apache.commons URL: https://github.com/apache/flink/pull/6966#discussion_r229473954
########## File path: flink-libraries/flink-table-common/src/main/java/org/apache/flink/table/utils/EncodingUtils.java ########## @@ -40,14 +44,18 @@ private static final Base64.Decoder BASE64_DECODER = java.util.Base64.getUrlDecoder(); + private static final MessageDigest MD5_MESSAGE_DIGEST = getMd5MessageDigest(); Review comment: Would MD5_MESSAGE_DIGEST be accessed concurrently? afaik this is not thread safe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services