tillrohrmann commented on a change in pull request #6943: [FLINK-10632][e2e] Running general purpose testing job with failure in per-job mode URL: https://github.com/apache/flink/pull/6943#discussion_r229352991
########## File path: flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh ########## @@ -0,0 +1,160 @@ +#!/usr/bin/env bash +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +source "$(dirname "$0")"/common.sh +source "$(dirname "$0")"/common_ha.sh + +TEST_PROGRAM_JAR_NAME=DataStreamAllroundTestProgram.jar +TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-datastream-allround-test/target/${TEST_PROGRAM_JAR_NAME} +FLINK_LIB_DIR=${FLINK_DIR}/lib +JOB_ID="00000000000000000000000000000000" + +function ha_cleanup() { + # don't call ourselves again for another signal interruption + trap "exit -1" INT + # don't call ourselves again for normal exit + trap "" EXIT + + stop_watchdogs + kill_all 'StandaloneJobClusterEntryPoint' + shutdown_all + rm ${FLINK_LIB_DIR}/${TEST_PROGRAM_JAR_NAME} +} + +trap ha_cleanup INT +trap ha_cleanup EXIT + +function run_job() { + local PARALLELISM=$1 + local BACKEND=$2 + local ASYNC=$3 + local INCREM=$4 + + local CHECKPOINT_DIR="${TEST_DATA_DIR}/checkpoints/" + + ${FLINK_DIR}/bin/standalone-job.sh start \ + --job-classname org.apache.flink.streaming.tests.DataStreamAllroundTestProgram \ + -p ${PARALLELISM} \ Review comment: Is this really needed? I think that setting `environment.parallelism` should already be enough. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
