[
https://issues.apache.org/jira/browse/FLINK-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665232#comment-16665232
]
ASF GitHub Bot commented on FLINK-10623:
----------------------------------------
dawidwys commented on a change in pull request #6926: [FLINK-10623][e2e]
Extended sql-client e2e test with MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/6926#discussion_r228542484
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamMatchRule.scala
##########
@@ -42,11 +42,13 @@ class DataStreamMatchRule
RelOptRule.convert(logicalMatch.getInput, FlinkConventions.DATASTREAM)
try {
- Class.forName("org.apache.flink.cep.pattern.Pattern")
+ Class
+ .forName("org.apache.flink.cep.pattern.Pattern",
+ false,
+ Thread.currentThread().getContextClassLoader)
} catch {
case ex: ClassNotFoundException => throw new TableException(
- "MATCH RECOGNIZE clause requires flink-cep dependency to be present on
the classpath.",
- ex)
+ "MATCH RECOGNIZE clause requires flink-cep dependency to be present on
the classpath.")
Review comment:
The thing is we shouldn't, because:
- sql-client prints only the root cause
- we already know what is the original exception. There is only one possible
exception there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Extend streaming SQL end-to-end test to test MATCH_RECOGNIZE
> ------------------------------------------------------------
>
> Key: FLINK-10623
> URL: https://issues.apache.org/jira/browse/FLINK-10623
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL, Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> We should extend the existing {{test_streaming_sql.sh}} to test the newly
> added {{MATCH_RECOGNIZE}} functionality.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
