[
https://issues.apache.org/jira/browse/FLINK-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663977#comment-16663977
]
ASF GitHub Bot commented on FLINK-10679:
----------------------------------------
tzulitai opened a new pull request #6930: [FLINK-10679] Remove deprecated
CompatibilityResult and related classes from framework code
URL: https://github.com/apache/flink/pull/6930
## What is the purpose of the change
The main purpose of this PR is the following:
1) The now deprecated `CompatibilityResult` and related classes (such as
`CompatibilityUtil` and `UnloadableDummyTypeSerializer`) should no longer leak
into Flink's framework code.
2) This requires letting the new
`TypeSerializerSchemaCompatibility#resolveSchemaCompatibility` method be the
only entry point for compatibility checks.
3) `TypeSerializerConfigSnapshot#resolveSchemaCompatibility` should then
serve as the adapter to delegate compatibility checks back to the serializer's
`ensureComaptibility` method.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (**yes** / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Let TypeSerializerSchemaCompatibility.resolveSchemaCompatibility() be the
> entry point for compatibility checks in framework code
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-10679
> URL: https://issues.apache.org/jira/browse/FLINK-10679
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing, Type Serialization System
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Stephan Ewen
> Priority: Major
> Labels: pull-request-available
>
> Currently, the state backend framework code still is exposed the now
> deprecated {{CompatibilityResult}} and relevant classes.
> Instead, all compatibility checks should go through the new
> {{TypeSerializerSchemaCompatibility#resolveSchemaCompatibility}} method, and
> allow framework code to check against the more powerful
> {{TypeSerializerSchemaCompatibility}} for incompatibility / migration
> requirements.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
