[GitHub] tillrohrmann commented on a change in pull request #6898: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler

[GitBox]

tillrohrmann commented on a change in pull request #6898: [FLINK-10431] 
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r228104451
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolTest.java
 ##########
 @@ -404,7 +392,7 @@ public void testReleaseResource() throws Exception {
         */
        @Test
        public void testSlotRequestCancellationUponFailingRequest() throws 
Exception {
-               final SlotPool slotPool = new SlotPool(rpcService, jobId, 
LocationPreferenceSchedulingStrategy.getInstance());
+               final SlotPool slotPool = new SlotPool( jobId, 
LocationPreferenceSchedulingStrategy.getInstance());
 
 Review comment:
   whitespace after `(`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services