[
https://issues.apache.org/jira/browse/FLINK-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658802#comment-16658802
]
ASF GitHub Bot commented on FLINK-10002:
----------------------------------------
ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226235686
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/files/StaticFileServerHandler.java
##########
@@ -128,30 +132,39 @@ public StaticFileServerHandler(
protected void respondAsLeader(ChannelHandlerContext
channelHandlerContext, RoutedRequest routedRequest, T gateway) throws Exception
{
final HttpRequest request = routedRequest.getRequest();
final String requestPath;
+ final FileOffsetRange range;
// make sure we request the "index.html" in case there is a
directory request
if (routedRequest.getPath().endsWith("/")) {
requestPath = routedRequest.getPath() + "index.html";
+ range = FileOffsetRange.MAX_FILE_OFFSET_RANGE;
+ } else if
(historicalLogPattern.matcher(routedRequest.getPath()).find()) {
+ Matcher m =
historicalLogPattern.matcher(routedRequest.getPath());
+ m.find();
+ requestPath = m.group(1);
+ range = FileOffsetRange.generateRange(m.group(2));
}
// in case the files being accessed are logs or stdout files,
find appropriate paths.
- else if (routedRequest.getPath().equals("/jobmanager/log") ||
routedRequest.getPath().equals("/jobmanager/stdout")) {
Review comment:
We should remove these log related codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> WebUI shows logs unfriendly, especially when the amount of logs is large
> ------------------------------------------------------------------------
>
> Key: FLINK-10002
> URL: https://issues.apache.org/jira/browse/FLINK-10002
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: zhangxinyu
> Assignee: zhangxinyu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Attachments: image-2018-09-10-11-38-07-973.png
>
>
> When a streaming job run for a long time, the amount of logs may be very
> large. The current WebUI shows all content of logs. It will cost much time to
> download logs from task managers. and the browser cannot display the logs.
> Therefore, I suggest that Flink uses DailyRollingAppender to split logs by
> default, and task manager provides an API that can get logs based on a
> parameter of time interval. In this way WebUI can display logs based on time
> interval.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
