[
https://issues.apache.org/jira/browse/FLINK-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653125#comment-16653125
]
ASF GitHub Bot commented on FLINK-10166:
----------------------------------------
leanken edited a comment on issue #6863: [FLINK-10166][table] skip relocation
of commons-codec and commons-lang3 from flink-table
URL: https://github.com/apache/flink/pull/6863#issuecomment-430521113
> Hi @leanken . Thank you for your contribution. I am afraid though it is
not the right way to proceed with this bug. I think we should rather cut off
usage of `Base64` (replace with our own implementation) than add hard external
dependencies.
---- "reply: for Base64 replacement. I think it's ok for just this single
case, what if there are even more cases like Base64, in future, we might need
to do the replacement case by case"
>
> Also just to clarify why we relocate dependencies. The reason is not just
so they do not clash with other dependencies of ours (e.g. from calcite as you
said), but also so that Flink's users can use any arbitrary version of popular
libraries.
---- "reply: the reason that you mentioned, user can use any version of
org.apache.commons prefix library, I dont think it is now working, because in
flink-binary-with-hadoop common-codec library already included in classpath,
even if FlinkUserJar contains its own common-codec jar, it might be conflict
during runtime"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dependency problems when executing SQL query in sql-client
> ----------------------------------------------------------
>
> Key: FLINK-10166
> URL: https://issues.apache.org/jira/browse/FLINK-10166
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: Dawid Wysakowicz
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> When tried to run query:
> {code}
> select count(distinct name) from (Values ('a'), ('b')) AS NameTable(name)
> {code}
> in {{sql-client.sh}} I got:
> {code}
> [ERROR] Could not execute SQL statement. Reason:
> org.codehaus.commons.compiler.CompileException: Line 43, Column 10: Unknown
> variable or type "org.apache.commons.codec.binary.Base64"
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
