yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r225370366
########## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala ########## @@ -889,6 +916,69 @@ class ScalarFunctionsTest extends ScalarTypesTestBase { "") } + @Test + def testChr(): Unit = { + testAllApis( + 'f14.chr(), + "f14.chr()", + "CHR(f14)", + "null") + + testAllApis( + 'f34.chr(), + "f34.chr()", + "CHR(f34)", + "null") + + testAllApis( + 'f34.chr(), + "f34.chr()", + "CHR(f34)", + "null") + + testAllApis( + 'f36.chr(), + "f36.chr()", + "CHR(f36)", + "A") + + testAllApis( + 'f37.chr(), + "f37.chr()", + "CHR(f37)", + "a") + + testAllApis( + 'f38.chr(), + "f38.chr()", + "CHR(f38)", + "ΓΏ") + + testAllApis( Review comment: There are three test cases that seem to be duplicates, but their SQL functions pass different input types for verification purposes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services