[
https://issues.apache.org/jira/browse/FLINK-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648350#comment-16648350
]
ASF GitHub Bot commented on FLINK-10508:
----------------------------------------
TisonKun commented on issue #6834: [FLINK-10508] [tests] Port JobManagerITCase
to new code base
URL: https://github.com/apache/flink/pull/6834#issuecomment-429436854
After some commits above, `JobManagerITCase` remains 4 tests which I am not
quite sure how to process them. Thus I'd like to cc @tillrohrmann and @tzulitai
for advice.
1. `"JobManagerITCase.The JobManager actor must remove execution graphs when
the client ends the session explicitly"` and `"JobManagerITCase.The JobManager
actor must remove execution graphs when when the client's session times out"`,
since `sessionTimeout` looks like not be used anymore in FLIP-6 codebase, and
execution graph archive mechanisms different, I tend to remove them.
@tillrohrmann
2. `"JobManagerITCase.The JobManager actor must handle trigger savepoint
response after trigger savepoint failure"` and `"JobManagerITCase.The
JobManager actor must handle failed savepoint triggering"`, these two tests
check "message" of trigger savepoint fail. Since FLIP-6 is not directly based
on Akka, I don't think it is necessary for these checks, so tend to remove
them. However, I want to know if we have tests to cover negative cases of
savepoint @tzulitai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port JobManagerITCase to new code base
> --------------------------------------
>
> Key: FLINK-10508
> URL: https://issues.apache.org/jira/browse/FLINK-10508
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: TisonKun
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerITCase}} to new code base.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
