[
https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648072#comment-16648072
]
ASF GitHub Bot commented on FLINK-9697:
---------------------------------------
aljoscha commented on issue #6703: [FLINK-9697] Provide connector for Kafka
2.0.0
URL: https://github.com/apache/flink/pull/6703#issuecomment-429374391
@yanghua Thanks for iterating on this so quickly! I will do a last thorough
review next week and then hopefully merge.
To make the reviewing easier you could restructure the commits a bit. All
prerequisite work should go into isolated commits and then the last commit
should only have the new files for the Kafka 2.0 connector. For example the
dependency change would be separate, or renaming the `KafkaTableSource` to
`KafkaTableSourceBase` can be separate to more clearly see what each change
does. This makes it way easier in the feature when someone looks at the changes
and tries to figure out what was going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide connector for Kafka 2.0.0
> ---------------------------------
>
> Key: FLINK-9697
> URL: https://issues.apache.org/jira/browse/FLINK-9697
> Project: Flink
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> Kafka 2.0.0 would be released soon.
> Here is vote thread:
> [http://search-hadoop.com/m/Kafka/uyzND1vxnEd23QLxb?subj=+VOTE+2+0+0+RC1]
> We should provide connector for Kafka 2.0.0 once it is released.
> Upgrade to 2.0 documentation :
> http://kafka.apache.org/20/documentation.html#upgrade_2_0_0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
