[ 
https://issues.apache.org/jira/browse/FLINK-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647534#comment-16647534
 ] 

Bowen Li commented on FLINK-10168:
----------------------------------

On a second thought to extend my comment on making this function similar to 
message queues' start position function, I feel defining it as a filter API 
would make it actually more complex than user anticipation. 

How about just providing a {{startPosition}} param to {{readFile() API}} to 
make it as simple as those in Flink's Kinesis/Kafka consumers? [~kkl0u] 
[~fhueske]

This way, it also might be even easier for Flink's SQL to parse when we need to 
add SQL file sources in the future.

> support filtering files by modified/created time in 
> StreamExecutionEnvironment.readFile()
> -----------------------------------------------------------------------------------------
>
>                 Key: FLINK-10168
>                 URL: https://issues.apache.org/jira/browse/FLINK-10168
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.6.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.7.0
>
>
> support filtering files by modified/created time in 
> {{StreamExecutionEnvironment.readFile()}}
> for example, in a source dir with lots of file, we only want to read files 
> that is created or modified after a specific time.
> This API can expose a generic filter function of files, and let users define 
> filtering rules. Currently Flink only supports filtering files by path. What 
> this means is that, currently the API is 
> {{FileInputFormat.setFilesFilters(PathFiter)}} that takes only one file path 
> filter. A more generic API that can take more filters can look like this 1) 
> {{FileInputFormat.setFilesFilters(List (PathFiter, ModifiedTileFilter, ... 
> ))}}
> 2) or {{FileInputFormat.setFilesFilters(FileFiter),}} and {{FileFilter}} 
> exposes all file attributes that Flink's file system can provide, like path 
> and modified time
> I lean towards the 2nd option, because it gives users more flexibility to 
> define complex filtering rules based on combinations of file attributes.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to