zhijiangW commented on a change in pull request #6809: [FLINK-10491][network]
Pass BufferPoolOwner in the constructor of LocalBufferPool
URL: https://github.com/apache/flink/pull/6809#discussion_r223929542
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -209,8 +209,11 @@ public void setupPartition(ResultPartition partition)
throws IOException {
int maxNumberOfMemorySegments =
partition.getPartitionType().isBounded() ?
partition.getNumberOfSubpartitions() *
networkBuffersPerChannel +
extraNetworkBuffersPerGate :
Integer.MAX_VALUE;
+ // If the partition type is back pressure-free, we
register with the buffer pool for
+ // callbacks to release memory.
bufferPool =
networkBufferPool.createBufferPool(partition.getNumberOfSubpartitions(),
- maxNumberOfMemorySegments);
+ maxNumberOfMemorySegments,
partition.getPartitionType().hasBackPressure() ? partition : null);
Review comment:
That is my careless, and find previous missing tests as a result. :)
I will add related test to cover it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
