[ 
https://issues.apache.org/jira/browse/FLINK-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643137#comment-16643137
 ] 

ASF GitHub Bot commented on FLINK-10135:
----------------------------------------

zentol commented on a change in pull request #6702: [FLINK-10135] The 
JobManager does not report the cluster-level metrics
URL: https://github.com/apache/flink/pull/6702#discussion_r223627773
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
 ##########
 @@ -909,6 +913,11 @@ private void clearDispatcherState() {
                terminateJobManagerRunners();
        }
 
+       private void registerJobSpecificMetrics(MetricGroup 
jobManagerMetricGroup) {
 
 Review comment:
   the name is slightly misleading; I would expect this to register metrics 
about a particular job(s). It would be fine to call this 
`registerDispatcherMetrics`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The JobManager doesn't report the cluster-level metrics
> -------------------------------------------------------
>
>                 Key: FLINK-10135
>                 URL: https://issues.apache.org/jira/browse/FLINK-10135
>             Project: Flink
>          Issue Type: Bug
>          Components: JobManager, Metrics
>    Affects Versions: 1.5.0, 1.6.0, 1.7.0
>            Reporter: Joey Echeverria
>            Assignee: vinoyang
>            Priority: Critical
>              Labels: pull-request-available
>
> In [the documentation for 
> metrics|https://ci.apache.org/projects/flink/flink-docs-release-1.5/monitoring/metrics.html#cluster]
>  in the Flink 1.5.0 release, it says that the following metrics are reported 
> by the JobManager:
> {noformat}
> numRegisteredTaskManagers
> numRunningJobs
> taskSlotsAvailable
> taskSlotsTotal
> {noformat}
> In the job manager REST endpoint 
> ({{http://<job-manager>:8081/jobmanager/metrics}}), those metrics don't 
> appear.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to