[
https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643001#comment-16643001
]
ASF GitHub Bot commented on FLINK-8302:
---------------------------------------
pnowojski commented on a change in pull request #6445: [FLINK-8302] [table] Add
SHIFT_LEFT and SHIFT_RIGHT
URL: https://github.com/apache/flink/pull/6445#discussion_r223611771
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
##########
@@ -74,6 +74,103 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
"true")
}
+ @Test
+ def testShiftLeft(): Unit = {
+ testAllApis(
+ 3.shiftLeft(3),
+ "3.shiftLeft(3)",
+ "shift_left(3,3)",
+ "24"
+ )
+
+ testAllApis(
+ 2147483647.shiftLeft(-2147483648),
+ "2147483647.shiftLeft(-2147483648)",
+ "SHIFT_LEFT(2147483647,-2147483648)",
+ "2147483647"
+ )
+
+ testAllApis(
+ -2147483648.shiftLeft(2147483647),
+ "-2147483648.shiftLeft(2147483647)",
+ "SHIFT_LEFT(-2147483648,2147483647)",
+ "0"
+ )
+
+ testAllApis(
+ 9223372036854775807L.shiftLeft(-2147483648),
+ "9223372036854775807L.shiftLeft(-2147483648)",
+ "SHIFT_LEFT(9223372036854775807,-2147483648)",
+ "9223372036854775807"
+ )
+
+ testAllApis(
+ 'f3.shiftLeft(5),
+ "f3.shiftLeft(5)",
+ "SHIFT_LEFT(f3,5)",
+ "32"
+ )
+
+ testAllApis(
+ 1.shiftLeft(Null(Types.INT)),
+ "1.shiftLeft(Null(INT))",
+ "SHIFT_LEFT(1, CAST(NULL AS INT))",
+ "null"
+ )
Review comment:
What about other types? `TINYINT`? `SMALLINT`? What happens if you pass
double or decimal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support shift_left and shift_right in TableAPI
> ----------------------------------------------
>
> Key: FLINK-8302
> URL: https://issues.apache.org/jira/browse/FLINK-8302
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: DuBin
> Priority: Major
> Labels: features, pull-request-available
> Fix For: 1.7.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Add shift_left and shift_right support in TableAPI, shift_left(input, n) act
> as input << n, shift_right(input, n) act as input >> n.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
