[ 
https://issues.apache.org/jira/browse/FLINK-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640188#comment-16640188
 ] 

ASF GitHub Bot commented on FLINK-10454:
----------------------------------------

tillrohrmann closed pull request #6799: [FLINK-10454][tests] Start MiniCluster 
with rest port 0
URL: https://github.com/apache/flink/pull/6799
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
 
b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
index 6d58928d5e9..7782a8e2feb 100644
--- 
a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
+++ 
b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
@@ -20,6 +20,7 @@
 
 import org.apache.flink.configuration.AkkaOptions;
 import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.RestOptions;
 import org.apache.flink.runtime.client.JobExecutionException;
 import org.apache.flink.runtime.execution.Environment;
 import org.apache.flink.runtime.io.network.api.reader.RecordReader;
@@ -41,6 +42,11 @@
 
 import java.util.BitSet;
 
+/**
+ * Tests that Flink can execute jobs with a higher parallelism than available 
number
+ * of slots. This effectively tests that Flink can execute jobs with blocking 
results
+ * in a staged fashion.
+ */
 public class SlotCountExceedingParallelismTest extends TestLogger {
 
        // Test configuration
@@ -55,6 +61,7 @@
        @BeforeClass
        public static void setUp() throws Exception {
                final Configuration config = new Configuration();
+               config.setInteger(RestOptions.PORT, 0);
                config.setString(AkkaOptions.ASK_TIMEOUT, 
TestingUtils.DEFAULT_AKKA_ASK_TIMEOUT());
 
                final MiniClusterConfiguration miniClusterConfiguration = new 
MiniClusterConfiguration.Builder()
diff --git 
a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/ScheduleOrUpdateConsumersTest.java
 
b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/ScheduleOrUpdateConsumersTest.java
index aee526dc153..eab4eabd6aa 100644
--- 
a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/ScheduleOrUpdateConsumersTest.java
+++ 
b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/ScheduleOrUpdateConsumersTest.java
@@ -20,6 +20,7 @@
 
 import org.apache.flink.configuration.AkkaOptions;
 import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.RestOptions;
 import org.apache.flink.runtime.execution.Environment;
 import org.apache.flink.runtime.io.network.api.writer.RecordWriter;
 import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
@@ -44,6 +45,10 @@
 
 import static 
org.apache.flink.runtime.jobmanager.SlotCountExceedingParallelismTest.SubtaskIndexReceiver.CONFIG_KEY;
 
+/**
+ * Tests for the lazy scheduling/updating of consumers depending on the
+ * producers result.
+ */
 public class ScheduleOrUpdateConsumersTest extends TestLogger {
 
        private static final int NUMBER_OF_TMS = 2;
@@ -55,6 +60,7 @@
        @BeforeClass
        public static void setUp() throws Exception {
                final Configuration config = new Configuration();
+               config.setInteger(RestOptions.PORT, 0);
                config.setString(AkkaOptions.ASK_TIMEOUT, 
TestingUtils.DEFAULT_AKKA_ASK_TIMEOUT());
 
                final MiniClusterConfiguration miniClusterConfiguration = new 
MiniClusterConfiguration.Builder()
@@ -89,7 +95,7 @@ public static void tearDown() throws Exception {
         *                             +----------+
         * </pre>
         *
-        * The pipelined receiver gets deployed after the first buffer is 
available and the blocking
+        * <p>The pipelined receiver gets deployed after the first buffer is 
available and the blocking
         * one after all subtasks are finished.
         */
        @Test
@@ -136,9 +142,13 @@ public void testMixedPipelinedAndBlockingResults() throws 
Exception {
 
        // 
---------------------------------------------------------------------------------------------
 
+       /**
+        * Invokable which writes a configurable number of events to a pipelined
+        * and blocking partition alternatingly.
+        */
        public static class BinaryRoundRobinSubtaskIndexSender extends 
AbstractInvokable {
 
-               public static final String CONFIG_KEY = 
"number-of-times-to-send";
+               static final String CONFIG_KEY = "number-of-times-to-send";
 
                public BinaryRoundRobinSubtaskIndexSender(Environment 
environment) {
                        super(environment);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Travis fails on ScheduleOrUpdateConsumersTest
> ---------------------------------------------
>
>                 Key: FLINK-10454
>                 URL: https://issues.apache.org/jira/browse/FLINK-10454
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: tison
>            Assignee: Till Rohrmann
>            Priority: Critical
>              Labels: pull-request-available, test-stability
>             Fix For: 1.7.0
>
>
> Can even be reproduced locally. Maybe a duplicate but as a reminder.
> {code:java}
> org.apache.flink.runtime.jobmanager.scheduler.ScheduleOrUpdateConsumersTest 
> Time elapsed: 4.514 sec <<< ERROR! java.net.BindException: Address already in 
> use at sun.nio.ch.Net.bind0(Native Method) at 
> sun.nio.ch.Net.bind(Net.java:433) at sun.nio.ch.Net.bind(Net.java:425) at 
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223) at 
> org.apache.flink.shaded.netty4.io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:128)
>  at 
> org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:558)
>  at 
> org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1358)
>  at 
> org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:501)
>  at 
> org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:486)
>  at 
> org.apache.flink.shaded.netty4.io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:1019)
>  at 
> org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannel.bind(AbstractChannel.java:254)
>  at 
> org.apache.flink.shaded.netty4.io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:366)
>  at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
>  at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
>  at 
> org.apache.flink.shaded.netty4.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463)
>  at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884)
>  at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to