twalthr commented on a change in pull request #6791: [FLINK-8865][sql-client]
Add CLI query code completion in SQL Client
URL: https://github.com/apache/flink/pull/6791#discussion_r223034776
##########
File path:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -233,6 +238,36 @@ public String explainStatement(SessionContext session,
String statement) throws
}
}
+ public org.apache.calcite.schema.Table getTable(SessionContext session,
String name) throws SqlExecutionException {
Review comment:
Please implement a better separation of concerns. The executor interface
might be used for a REST API in the future (see FLIP-24). So this method should
not expose internal Calcite classes but only information about how to complete
the SQL query.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
