[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639193#comment-16639193 ]
ASF GitHub Bot commented on FLINK-10247: ---------------------------------------- Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#discussion_r222880749 ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java ########## @@ -402,9 +438,9 @@ private Configuration generateClusterConfiguration(Configuration configuration) } private CompletableFuture<ApplicationStatus> shutDownAsync( - ApplicationStatus applicationStatus, - @Nullable String diagnostics, - boolean cleanupHaData) { + ApplicationStatus applicationStatus, + @Nullable String diagnostics, + boolean cleanupHaData) { Review comment: OK ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run MetricQueryService in separate thread pool > ---------------------------------------------- > > Key: FLINK-10247 > URL: https://issues.apache.org/jira/browse/FLINK-10247 > Project: Flink > Issue Type: Sub-task > Components: Metrics > Affects Versions: 1.5.3, 1.6.0, 1.7.0 > Reporter: Till Rohrmann > Assignee: Shimin Yang > Priority: Critical > Labels: pull-request-available > Fix For: 1.7.0, 1.6.2, 1.5.5 > > > In order to make the {{MetricQueryService}} run independently of the main > Flink components, it should get its own dedicated thread pool assigned. -- This message was sent by Atlassian JIRA (v7.6.3#76005)