[ https://issues.apache.org/jira/browse/FLINK-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632833#comment-16632833 ]
ASF GitHub Bot commented on FLINK-10340: ---------------------------------------- yanghua commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6700#discussion_r221417745 ########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/mathExpressions.scala ########## @@ -104,6 +104,21 @@ case class Log2(child: Expression) extends UnaryExpression with InputTypeSpec { override def toString: String = s"log2($child)" } +case class Cosh(child: Expression) extends UnaryExpression with InputTypeSpec { Review comment: agree, It is not necessary to inherit it and will remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Cosh math function supported in Table API and SQL > ----------------------------------------------------- > > Key: FLINK-10340 > URL: https://issues.apache.org/jira/browse/FLINK-10340 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Affects Versions: 1.6.0 > Reporter: Sergey Tsvetkov > Assignee: vinoyang > Priority: Minor > Labels: pull-request-available > > Implement udf of cosh, just like in oracle > [https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions031.htm#SQLRF00623] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)