[
https://issues.apache.org/jira/browse/FLINK-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632754#comment-16632754
]
ASF GitHub Bot commented on FLINK-10403:
----------------------------------------
TisonKun commented on a change in pull request #6751: [FLINK-10403] Port
JobManagerHAProcessFailureBatchRecoveryITCase to new code base
URL: https://github.com/apache/flink/pull/6751#discussion_r221413841
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureBatchRecoveryITCase.java
##########
@@ -141,15 +151,14 @@ public
JobManagerHAProcessFailureBatchRecoveryITCase(ExecutionMode executionMode
*/
private void testJobManagerFailure(String zkQuorum, final File
coordinateDir, final File zookeeperStoragePath) throws Exception {
Configuration config = new Configuration();
- config.setString(CoreOptions.MODE, CoreOptions.LEGACY_MODE);
config.setString(HighAvailabilityOptions.HA_MODE, "ZOOKEEPER");
config.setString(HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM,
zkQuorum);
config.setString(HighAvailabilityOptions.HA_STORAGE_PATH,
zookeeperStoragePath.getAbsolutePath());
ExecutionEnvironment env =
ExecutionEnvironment.createRemoteEnvironment(
"leader", 1, config);
env.setParallelism(PARALLELISM);
- env.setNumberOfExecutionRetries(1);
+ env.setRestartStrategy(RestartStrategies.fixedDelayRestart(1,
0L));
env.getConfig().setExecutionMode(executionMode);
Review comment:
Hi @tillrohrmann , I want to know how `ExecutionMode` affect
`DataExchangeMode` here. If I understand it correctly, this test case tests
both `BATCH` and `PIPELINED` `DataExchangeMode`. But only `.rebalance()` here,
I think I have to learn which type `rebalance` belong to.
Further, maybe I can port `JobManagerFailsITCase` based on this case, even
some are covered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Port JobManagerHAProcessFailureBatchRecoveryITCase to new code base
> -------------------------------------------------------------------
>
> Key: FLINK-10403
> URL: https://issues.apache.org/jira/browse/FLINK-10403
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Port {{JobManagerHAProcessFailureBatchRecoveryITCase}} to new code base.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
