Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r36955221
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
---
@@ -69,14 +68,14 @@ public void run(SourceContext<String> ctx) throws
Exception {
public void streamFromSocket(SourceContext<String> ctx, Socket socket)
throws Exception {
--- End diff --
I think this method should be private because it is not meant to be used
outside this class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
