[ 
https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631538#comment-16631538
 ] 

ASF GitHub Bot commented on FLINK-10247:
----------------------------------------

Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics] 
Run MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#discussion_r221180466
 
 

 ##########
 File path: docs/_includes/generated/task_manager_configuration.html
 ##########
 @@ -92,6 +92,11 @@
             <td style="word-wrap: break-word;">"0"</td>
             <td>Amount of memory to be allocated by the task manager's memory 
manager. If not set, a relative fraction will be allocated.</td>
         </tr>
+        <tr>
+            <td><h5>taskmanager.metric-query-service.rpc.port</h5></td>
+            <td style="word-wrap: break-word;">"0"</td>
+            <td>The metric query service’s IPC port. Accepts a list of ports 
(“50100,50101”), ranges (“50100-50200”) or a combination of both. It is 
recommended to set a range of ports to avoid collisions when multiple metric 
query service are running on the same machine.</td>
 
 Review comment:
   I googled IPC and find it means inter process connection, also copied from 
the taskmanager.rpc.port. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run MetricQueryService in separate thread pool
> ----------------------------------------------
>
>                 Key: FLINK-10247
>                 URL: https://issues.apache.org/jira/browse/FLINK-10247
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics
>    Affects Versions: 1.5.3, 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Shimin Yang
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> In order to make the {{MetricQueryService}} run independently of the main 
> Flink components, it should get its own dedicated thread pool assigned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to