zentol commented on a change in pull request #6763: [FLINK-10415] Fail response
future if connection closes in RestClient
URL: https://github.com/apache/flink/pull/6763#discussion_r220642737
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java
##########
@@ -339,12 +338,26 @@ private static Request createRequest(String
targetAddress, String targetUrl, Htt
.thenComposeAsync(
channel -> {
ClientHandler handler =
channel.pipeline().get(ClientHandler.class);
- CompletableFuture<JsonResponse> future
= handler.getJsonFuture();
+
+ CompletableFuture<JsonResponse> future;
+ boolean success = false;
+
try {
- httpRequest.writeTo(channel);
+ if (handler == null) {
+ throw new
IOException("Netty pipeline was not properly initialized.");
+ } else {
+
httpRequest.writeTo(channel);
+ future =
handler.getJsonFuture();
+ success = true;
+ }
} catch (IOException e) {
- return
FutureUtils.completedExceptionally(new FlinkException("Could not write
request.", e));
+ future =
FutureUtils.completedExceptionally(new ConnectionException("Could not write
request.", e));
+ } finally {
+ if (!success) {
+ channel.close();
Review comment:
why aren't we closing the channel in both cases? Not being initialized
_properly_ doesn't necessarily mean that there's nothing to clean up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
