TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r220236164
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java ########## @@ -429,7 +413,7 @@ public void testFailExternallyDuringInvoke() { awaitLatch.await(); task.failExternally(new Exception("test")); - assertTrue(task.getExecutionState() == ExecutionState.FAILED); Review comment: @Clarkkkkk Thanks for your review! Please see also my first comment. `TaskTest` is a test based on legacy code, would be ported to FLIP-6 codebase soon as a sub task of FLINK-10392. All changes under `TaskTest` is temporary. Once the porting job done and if this PR doesn't get merged then, I would do a rebase. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services