[
https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627237#comment-16627237
]
ASF GitHub Bot commented on FLINK-10247:
----------------------------------------
Clarkkkkk opened a new pull request #6759: [FLINK-10247][Metrics] Run
MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759
## What is the purpose of the change
After discussion with @tillrohrmann, instead of using a thread pool to
handle the metric query service message, starting a dedicated actor system in
each TM and JM would provide better isolation between metric query service and
main component rpc service.
## Brief change log
- Refactored the Akka related util to support an actor system with single
thread low priority executor.
- Add metric query service port options to TM and JM configuration
- Started the metric query service use a dedicated actor system in
ClusterEntry point and TaskManagerRunner
## Verifying this change
This change is already covered by existing tests, such as AkkaUtilsTest and
MetricQueryServiceTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Run MetricQueryService in separate thread pool
> ----------------------------------------------
>
> Key: FLINK-10247
> URL: https://issues.apache.org/jira/browse/FLINK-10247
> Project: Flink
> Issue Type: Sub-task
> Components: Metrics
> Affects Versions: 1.5.3, 1.6.0, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Shimin Yang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> In order to make the {{MetricQueryService}} run independently of the main
> Flink components, it should get its own dedicated thread pool assigned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
