bmeriaux commented on a change in pull request #6735: [FLINK-9126] New CassandraPojoInputFormat to output data as a custom annotated Cassandra Pojo URL: https://github.com/apache/flink/pull/6735#discussion_r219980389
########## File path: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraPojoInputFormat.java ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.batch.connectors.cassandra; + +import org.apache.flink.core.io.InputSplit; +import org.apache.flink.streaming.connectors.cassandra.ClusterBuilder; +import org.apache.flink.streaming.connectors.cassandra.MapperOptions; +import org.apache.flink.util.Preconditions; + +import com.datastax.driver.mapping.Mapper; +import com.datastax.driver.mapping.MappingManager; +import com.datastax.driver.mapping.Result; + +import java.io.IOException; + +/** + * InputFormat to read data from Apache Cassandra and generate a custom Cassandra annotated object. + * + * @param <OUT> type of inputClass + */ +public class CassandraPojoInputFormat<OUT> extends CassandraInputFormatBase<OUT> { + + private static final long serialVersionUID = 1992091320180905115L; + private final MapperOptions mapperOptions; + + private transient Result<OUT> resultSet; + private Class<OUT> inputClass; + + public CassandraPojoInputFormat(String query, ClusterBuilder builder, Class<OUT> inputClass) { + this(query, builder, inputClass, null); + } + + public CassandraPojoInputFormat(String query, ClusterBuilder builder, Class<OUT> inputClass, MapperOptions mapperOptions) { + super(query, builder); + this.mapperOptions = mapperOptions; + Preconditions.checkArgument(inputClass != null, "InputClass cannot be null"); Review comment: like previous one, i think we should stick on checkArgument to keep a IllegalArgumentException ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
