yanghua commented on issue #6567: [FLINK-10074] Allowable number of checkpoint 
failures
URL: https://github.com/apache/flink/pull/6567#issuecomment-423940208
 
 
   @azagrebin thanks for your suggestion, I agree and reconsider more details.
   
   Considering that @tillrohrmann  has said that the current checkpoint 
exception handler should also be implemented in `CheckpointCoordinator`. 
   
   > I understand why you implemented it the way you did. I think the 
`setFailOnCheckpointingErrors` should actually also be handled by the 
`CheckpointCoordinator`/`JM` and not on the Task level (but this is a different 
story). This looks a little bit like a shortcut we made back in the days.
   
   Do we need to take this refactoring into account? Because this PR is 
actually a supplement to the checkpoint exception handler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to