zentol commented on a change in pull request #6731: [FLINK-10312] Propagate
exception from server to client in REST API
URL: https://github.com/apache/flink/pull/6731#discussion_r219797592
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractRestHandler.java
##########
@@ -111,10 +112,13 @@ protected AbstractRestHandler(
private void processRestHandlerException(ChannelHandlerContext ctx,
HttpRequest httpRequest, RestHandlerException rhe) {
log.error("Exception occurred in REST handler.", rhe);
+ String serverSideExceptionMesssage = "\n<Exception on server
side:\n" +
+ ExceptionUtils.stringifyException(rhe) + "\nEnd of
exception on server side>";
+
HandlerUtils.sendErrorResponse(
ctx,
httpRequest,
- new ErrorResponseBody(rhe.getMessage()),
+ new ErrorResponseBody(Arrays.asList(rhe.getMessage(),
serverSideExceptionMesssage)),
Review comment:
We also may have to double-check that the list of errors is properly handled
in all places, like the client and WebUI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
