[
https://issues.apache.org/jira/browse/FLINK-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625008#comment-16625008
]
ASF GitHub Bot commented on FLINK-10291:
----------------------------------------
uce commented on a change in pull request #6733: [FLINK-10291] Generate
JobGraph with fixed/configurable JobID in StandaloneJobClusterEntrypoint
URL: https://github.com/apache/flink/pull/6733#discussion_r219690410
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPoint.java
##########
@@ -67,6 +68,8 @@
@Nonnull
private final SavepointRestoreSettings savepointRestoreSettings;
+ private final JobID jobID = new JobID(Long.MIN_VALUE, Long.MIN_VALUE);
Review comment:
The resulting `JobID` for this is: `80000000000000008000000000000000`.
What do you think about using `new JobID(0, 0)` to give an all zero `JobID`
instead? Since this is a fixed ID anyways, I think going with the simplest ID
is preferable and an all zero ID might be easier to use when manually working
with the REST API of a job instead of remembering to insert an `8` (which also
looks very similar to a `0`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Generate JobGraph with fixed/configurable JobID in
> StandaloneJobClusterEntrypoint
> ---------------------------------------------------------------------------------
>
> Key: FLINK-10291
> URL: https://issues.apache.org/jira/browse/FLINK-10291
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.6.0, 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.7.0, 1.6.2
>
>
> The {{StandaloneJobClusterEntrypoint}} currently generates the {{JobGraph}}
> from the user code when being started. Due to the nature of how the
> {{JobGraph}} is generated, it will get a random {{JobID}} assigned. This is
> problematic in case of a failover because then, the {{JobMaster}} won't be
> able to detect the checkpoints. In order to solve this problem, we need to
> either fix the {{JobID}} assignment or make it configurable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
