[
https://issues.apache.org/jira/browse/FLINK-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620438#comment-16620438
]
ASF GitHub Bot commented on FLINK-10355:
----------------------------------------
fhueske commented on a change in pull request #6713: [FLINK-10355][table]the
order of the columns start from 1
URL: https://github.com/apache/flink/pull/6713#discussion_r218750490
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/io/RowCsvInputFormat.java
##########
@@ -177,7 +177,7 @@ protected boolean parseRecord(Object[] holders, byte[]
bytes, int offset, int nu
// the error state EMPTY_COLUMN is
ignored
if (parser.getErrorState() !=
FieldParser.ParseErrorState.EMPTY_COLUMN) {
throw new
ParseException(String.format("Parsing error for column %1$s of row '%2$s'
originated by %3$s: %4$s.",
- field, new
String(bytes, offset, numBytes), parser.getClass().getSimpleName(),
parser.getErrorState()));
+ field+1, new
String(bytes, offset, numBytes), parser.getClass().getSimpleName(),
parser.getErrorState()));
Review comment:
This change does not pass the style check. Please add whitespaces around
`+`, i.e., -> `field + 1`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The order of the column should start from 1.
> --------------------------------------------
>
> Key: FLINK-10355
> URL: https://issues.apache.org/jira/browse/FLINK-10355
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: lihongli
> Priority: Major
> Labels: easyfix, pull-request-available
> Attachments: B0C32FD9-47FE-4F63-921F-A9E49C0CB5CD.png
>
>
> When I register an external Table using a CsvTableSource.It throws an
> exception :"Parsing error for column 1".But I finally found that the second
> column is the error column.I think that the order of the column should start
> from 1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
