[
https://issues.apache.org/jira/browse/FLINK-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619252#comment-16619252
]
ASF GitHub Bot commented on FLINK-10135:
----------------------------------------
StefanRRichter commented on a change in pull request #6702: [FLINK-10135] The
JobManager does not report the cluster-level metrics
URL: https://github.com/apache/flink/pull/6702#discussion_r218464627
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -554,6 +559,63 @@ private Configuration
generateClusterConfiguration(Configuration configuration)
return resultConfiguration;
}
+ private void instantiateJobManagerOverviewMetrics(MetricGroup
jobManagerMetricGroup) {
+ long defaultTimeoutValue =
configuration.getLong(RestOptions.CONNECTION_TIMEOUT);
+ Time defaultRequestTimeout =
Time.milliseconds(defaultTimeoutValue);
+
+ jobManagerMetricGroup.gauge("taskSlotsAvailable", () -> {
+ try {
+ return new Long(
Review comment:
I would prefer
`return (long)
resourceManager.requestResourceOverview(defaultRequestTimeout).get().getNumberTaskManagers();`.
There are more instances of this case below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The JobManager doesn't report the cluster-level metrics
> -------------------------------------------------------
>
> Key: FLINK-10135
> URL: https://issues.apache.org/jira/browse/FLINK-10135
> Project: Flink
> Issue Type: Bug
> Components: JobManager, Metrics
> Affects Versions: 1.5.0, 1.6.0, 1.7.0
> Reporter: Joey Echeverria
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
>
> In [the documentation for
> metrics|https://ci.apache.org/projects/flink/flink-docs-release-1.5/monitoring/metrics.html#cluster]
> in the Flink 1.5.0 release, it says that the following metrics are reported
> by the JobManager:
> {noformat}
> numRegisteredTaskManagers
> numRunningJobs
> taskSlotsAvailable
> taskSlotsTotal
> {noformat}
> In the job manager REST endpoint
> ({{http://<job-manager>:8081/jobmanager/metrics}}), those metrics don't
> appear.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
