[
https://issues.apache.org/jira/browse/FLINK-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618831#comment-16618831
]
ASF GitHub Bot commented on FLINK-10349:
----------------------------------------
azagrebin commented on a change in pull request #6701: [FLINK-10349] Unify
stopActor utils
URL: https://github.com/apache/flink/pull/6701#discussion_r218372604
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerRegistrationTest.java
##########
@@ -533,7 +532,7 @@ protected void run() {
// kill the first forwarding JobManager
watch(fakeJobManager1Gateway.actor());
- stopActor(fakeJobManager1Gateway.actor());
+
ActorUtils.stopActorsGracefully(fakeJobManager1Gateway.actor());
Review comment:
can be then just:
```
ActorUtils. stopActor(fakeJobManager1Gateway);
```
also the previous code used `stopActor` not gracefully, which might be
intended by the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unify stopActor utils
> ---------------------
>
> Key: FLINK-10349
> URL: https://issues.apache.org/jira/browse/FLINK-10349
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.7.0
> Reporter: 陈梓立
> Assignee: 陈梓立
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
