pnowojski commented on a change in pull request #6692: [FLINK-10331][network] reduce unnecesary flushing URL: https://github.com/apache/flink/pull/6692#discussion_r218325893
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateConcurrentTest.java ########## @@ -198,6 +199,8 @@ public void testConsumptionWithMixedChannels() throws Exception { private abstract static class Source { abstract void addBufferConsumer(BufferConsumer bufferConsumer) throws Exception; + + abstract void flush(); Review comment: Why did you need to add this `flush`? What was wrong? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services