tragicjun edited a comment on issue #6508: [Flink-10079] [table] Support external sink table in the INSERT INTO clause URL: https://github.com/apache/flink/pull/6508#issuecomment-422247049 Thanks @fhueske , looks like `var` in scala is not recommended, sorry that I'm still getting used to scala style. I've replaced it with an recursive internal function. As for the nesting `match` blocks, I would like to keep it consistent with similar cases in `StreamTableEnvironment.registerTableSinkInternal()` and `BatchTableEnvironment.registerTableSinkInternal()`, which I think is better than `if (table.tableSourceTable != None)` statement. What do you think? Or please just improve it if there is more clean way. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
