[ https://issues.apache.org/jira/browse/FLINK-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617154#comment-16617154 ]
ASF GitHub Bot commented on FLINK-10290: ---------------------------------------- jrthe42 commented on issue #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan URL: https://github.com/apache/flink/pull/6666#issuecomment-421909444 Hi @fhueske, I don't think `TableSchema` can help here, since `TableSchema` only reflects the structure of the abstracted Table, while the underlying datastream's TypeInformation is transparent. I'm agree with @twalthr , compare field names in `equals ` methods (just the same as `TupleTypeInformation`) seems a more reasonable way. What do you think? Best, JR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Conversion error in StreamScan and BatchScan > -------------------------------------------- > > Key: FLINK-10290 > URL: https://issues.apache.org/jira/browse/FLINK-10290 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Affects Versions: 1.5.3, 1.6.0 > Reporter: wangsan > Assignee: wangsan > Priority: Major > Labels: pull-request-available > > `RowTypeInfo#equals()` only compares field types, and fields names are not > considered. When checking the equality of `inputType` and `internalType`, we > should compare both filed types and field names. > Behavior of this bug: > A table T with schema (a: Long, b:Long, c:Long) > SELECT b,c,a from T > expected: b,c,a > actually: a,b,c -- This message was sent by Atlassian JIRA (v7.6.3#76005)