[ https://issues.apache.org/jira/browse/FLINK-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605910#comment-16605910 ]
ASF GitHub Bot commented on FLINK-7800: --------------------------------------- twalthr commented on issue #4934: [FLINK-7800] [table] Enable window joins without equi-join predicates URL: https://github.com/apache/flink/pull/4934#issuecomment-419133465 @xccui what is the status of this PR? You never received a review for it. Do you think the code is still valid and ready for a review? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable window joins without equi-join predicates > ------------------------------------------------ > > Key: FLINK-7800 > URL: https://issues.apache.org/jira/browse/FLINK-7800 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL > Affects Versions: 1.4.0 > Reporter: Fabian Hueske > Assignee: Xingcan Cui > Priority: Major > Labels: pull-request-available > > Currently, windowed joins can only be translated if they have at least on > equi-join predicate. This limitation exists due to the lack of a good cross > join strategy for the DataSet API. > Due to the window, windowed joins do not have to be executed as cross joins. > Hence, the equi-join limitation does not need to be enforces (even though > non-equi joins are executed with a parallelism of 1 right now). > We can resolve this issue by adding a boolean flag to the > {{FlinkLogicalJoinConverter}} rule to permit non-equi joins and add such a > rule to the logical optimization set of the DataStream API. -- This message was sent by Atlassian JIRA (v7.6.3#76005)