pnowojski commented on a change in pull request #6417: [FLINK-9913][runtime]
Improve output serialization only once in RecordWriter
URL: https://github.com/apache/flink/pull/6417#discussion_r215611435
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
##########
@@ -197,40 +214,39 @@ public void setMetricGroup(TaskIOMetricGroup metrics) {
* Marks the current {@link BufferBuilder} as finished and clears the
state for next one.
*/
private void tryFinishCurrentBufferBuilder(int targetChannel) {
- if (bufferBuilders[targetChannel].isPresent()) {
- BufferBuilder bufferBuilder =
bufferBuilders[targetChannel].get();
+ Optional<BufferBuilder> bufferBuilderOpt =
bufferBuilders[targetChannel];
+ if (bufferBuilderOpt.isPresent()) {
bufferBuilders[targetChannel] = Optional.empty();
- numBytesOut.inc(bufferBuilder.finish());
+ numBytesOut.inc(bufferBuilderOpt.get().finish());
numBuffersOut.inc();
}
}
-
+
/**
* The {@link BufferBuilder} may already exist if not filled up last
time, otherwise we need
* request a new one for this target channel.
*/
- @Nonnull
private BufferBuilder getBufferBuilder(int targetChannel) throws
IOException, InterruptedException {
- if (bufferBuilders[targetChannel].isPresent()) {
- return bufferBuilders[targetChannel].get();
+ Optional<BufferBuilder> bufferBuilderOpt =
bufferBuilders[targetChannel];
Review comment:
ditto: rename or inline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
