azagrebin commented on a change in pull request #6567: [FLINK-10074] Allowable 
number of checkpoint failures
URL: https://github.com/apache/flink/pull/6567#discussion_r215588426
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -875,6 +876,9 @@ public void run() {
                                                localTaskOperatorSubtaskStates,
                                                asyncDurationMillis);
 
+                                       if 
(owner.asynchronousCheckpointExceptionHandler != null) {
 
 Review comment:
   do you think it can be null? it is initialised in the beginning of the Task 
`invoke` and then used also in catch Exception: `handleExecutionException(e)` 
without any check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to