hequn8128 commented on a change in pull request #6648: [FLINK-10261][table] fix
insert into with order by
URL: https://github.com/apache/flink/pull/6648#discussion_r214773258
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/validation/InsertIntoValidationTest.scala
##########
@@ -47,6 +48,27 @@ class InsertIntoValidationTest {
tEnv.sqlUpdate(sql)
}
+ @Test(expected = classOf[TableException])
+ def testNonTimeOrderByInsert(): Unit = {
Review comment:
This test is used to test order by without time field. Would it better move
it into `org.apache.flink.table.api.stream.sql.validation.SortValidationTest` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
