zentol closed pull request #6591: [FLINK-10186] Fix FindBugs warnings: Random
object created and used o…
URL: https://github.com/apache/flink/pull/6591
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
index 7a0be33be61..4b690d1f750 100644
---
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
+++
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
@@ -35,7 +35,7 @@
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.nio.channels.FileChannel;
-import java.util.Random;
+import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.atomic.AtomicInteger;
/**
@@ -115,7 +115,7 @@ public BufferSpiller(IOManager ioManager, int pageSize)
throws IOException {
this.tempDir = tempDirs[DIRECTORY_INDEX.getAndIncrement() %
tempDirs.length];
byte[] rndBytes = new byte[32];
- new Random().nextBytes(rndBytes);
+ ThreadLocalRandom.current().nextBytes(rndBytes);
this.spillFilePrefix = StringUtils.byteToHexString(rndBytes) +
'.';
// prepare for first contents
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
