NicoK commented on a change in pull request #6555: [FLINK-10142][network]
reduce locking around credit notification
URL: https://github.com/apache/flink/pull/6555#discussion_r213966285
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
##########
@@ -170,6 +170,65 @@ public Void call() throws Exception {
}
}
+ @Test
+ public void testConcurrentNotifyBufferAvailableAndRelease() throws
Exception {
Review comment:
sorry, I did not miss it but forgot to react...
There are two things that I don't like about removing this test:
- how is `StreamNetworkThroughputBenchmarkTest#largeRemoteMode` a stress
test for concurrently releasing and notifying about new buffers?
- a benchmark should be about performance while a test should cover
correctness: even if a performance test does cover correctness at the moment,
that could too easily be changed in future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
